Skip to content

Rename the ErrorHandler component to ErrorCatcher #32227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Rename the ErrorHandler component to ErrorCatcher #32227

merged 1 commit into from
Jun 27, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jun 27, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 27, 2019
@fabpot fabpot force-pushed the error-handler-to-error-catcher branch from 5fba1b7 to 5ec8fd4 Compare June 27, 2019 16:32
lyrixx
lyrixx previously requested changes Jun 27, 2019
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update composer.json for other components: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/HttpKernel/composer.json#L20

@fabpot fabpot force-pushed the error-handler-to-error-catcher branch from 5ec8fd4 to 39c36c3 Compare June 27, 2019 16:32
@fabpot
Copy link
Member Author

fabpot commented Jun 27, 2019

@lyrixx fixed, thank you

@fabpot fabpot force-pushed the error-handler-to-error-catcher branch 3 times, most recently from 275735c to aec49d5 Compare June 27, 2019 16:36
@fabpot fabpot force-pushed the error-handler-to-error-catcher branch from aec49d5 to 669fb01 Compare June 27, 2019 16:47
@fabpot fabpot requested a review from sroze as a code owner June 27, 2019 16:47
@fabpot fabpot force-pushed the error-handler-to-error-catcher branch from 669fb01 to e5d3243 Compare June 27, 2019 16:50
@yceruto yceruto mentioned this pull request Jun 27, 2019
Merged
@fabpot fabpot force-pushed the error-handler-to-error-catcher branch from e5d3243 to 057546c Compare June 27, 2019 17:04
@fabpot fabpot force-pushed the error-handler-to-error-catcher branch 3 times, most recently from be30508 to d66331f Compare June 27, 2019 17:29
@fabpot fabpot force-pushed the error-handler-to-error-catcher branch from d66331f to b6eac3f Compare June 27, 2019 17:39
@fabpot fabpot mentioned this pull request Jun 27, 2019
Closed
@fabpot fabpot merged commit b6eac3f into symfony:4.4 Jun 27, 2019
fabpot added a commit that referenced this pull request Jun 27, 2019
@fabpot
feature #32227 Rename the ErrorHandler component to ErrorCatcher (fab…
45526a1 
…pot)

This PR was merged into the 4.4 branch.

Discussion
----------

Rename the ErrorHandler component to ErrorCatcher

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

b6eac3f renamed the ErrorHandler component to ErrorCatcher
stof
stof reviewed Jun 28, 2019
View reviewed changes
src/Symfony/Bundle/TwigBundle/composer.json
@@ -17,7 +17,7 @@
],
"require": {
"php": "^7.1.3",
"symfony/config": "^4.2|^5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requirement should be kept, as we do depend on it (and we should not rely on the transitive dependency coming from elsewhere)

@fabpot fabpot deleted the error-handler-to-error-catcher branch July 18, 2019 20:17
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof left review comments

@yceruto yceruto yceruto approved these changes

@Simperfit Simperfit Simperfit approved these changes

@lyrixx lyrixx lyrixx left review comments

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@fabpot @nicolas-grekas @lyrixx @stof @yceruto @Simperfit @carsonbot