[HttpClient] Add support for NTLM authentication #32231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jun 28, 2019
fabpot
approved these changes
Jul 3, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…las-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Add support for NTLM authentication | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Someone mentioned NTLM auth on Twitter, so here we are, this adds support for it. Requires curl. Commits ------- 548f4fd [HttpClient] Add support for NTLM authentication
apfelbox
reviewed
Jul 10, 2019
| @@ -181,6 +181,10 @@ private static function mergeDefaultOptions(array $options, array $defaultOption | |||
| } | |||
| } | |||
|
|
|||
| if ('auth_ntlm' === $name) { | |||
| throw new InvalidArgumentException(sprintf('Option "%s" is not supported by %s, try using CurlHttpClient instead.', __CLASS__)); | |||
There was a problem hiding this comment.
The option name is missing in the sprintf() call?
2 placeholders but only 1 value passed.
There was a problem hiding this comment.
good catch, could you please send a PR to fix it?
symfony-splitter
pushed a commit
to symfony/http-client
that referenced
this pull request
Jul 12, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Add missing message parameter | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony/symfony#32231 (comment) | License | MIT | Doc PR | — <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add the missing parameter in the `sprintf()` call. Found in symfony/symfony#32231 (comment) Commits ------- a060642637 Replace missing message parameter
fabpot
added a commit
that referenced
this pull request
Jul 12, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Add missing message parameter | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32231 (comment) | License | MIT | Doc PR | — <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add the missing parameter in the `sprintf()` call. Found in #32231 (comment) Commits ------- a060642 Replace missing message parameter
This was referenced Nov 12, 2019
Merged
Merged
sadafrangian3
pushed a commit
to sadafrangian3/Dependency-Injection-http-client
that referenced
this pull request
Nov 2, 2022
This PR was merged into the 4.4 branch. Discussion ---------- Add missing message parameter | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony/symfony#32231 (comment) | License | MIT | Doc PR | — <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add the missing parameter in the `sprintf()` call. Found in symfony/symfony#32231 (comment) Commits ------- a060642637 Replace missing message parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone mentioned NTLM auth on Twitter, so here we are, this adds support for it.
Requires curl.