-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PropertyAccess] Add type-hints to public interfaces and classes #32234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1704,7 +1704,7 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con | |
|
||
if (!$container->getParameter('kernel.debug')) { | ||
$propertyAccessDefinition->setFactory([PropertyAccessor::class, 'createCache']); | ||
$propertyAccessDefinition->setArguments([null, null, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]); | ||
$propertyAccessDefinition->setArguments([null, 0, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If that change is necessary, your I'd suggest that we backport this change to FrameworkBundle 4.4 along with a deprecation in |
||
$propertyAccessDefinition->addTag('cache.pool', ['clearer' => 'cache.system_clearer']); | ||
$propertyAccessDefinition->addTag('monolog.logger', ['channel' => 'cache']); | ||
} else { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be done in #32269 (we always document the deprecation and its removal in the same branch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a71ee27