[PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method #32241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jun 28, 2019
jschaedl
commented
Jun 28, 2019
derrabus
approved these changes
Jun 28, 2019
Tobion
approved these changes
Jun 28, 2019
Tobion
suggested changes
Jun 28, 2019
Tobion
approved these changes
Jun 28, 2019
fabpot
approved these changes
Jun 28, 2019
…argument in createCache method
2ff36fb to
9aac426
Compare
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jun 28, 2019
…efaultLifetime argument in createCache method (jschaedl) This PR was squashed before being merged into the 4.4 branch (closes #32241). Discussion ---------- [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A<!-- required for new features --> This PR is related to #32234 (comment) Commits ------- 9aac426 [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method
jschaedl
added a commit
to jschaedl/symfony
that referenced
this pull request
Jun 28, 2019
- this PR is related to symfony#32241
jschaedl
added a commit
to jschaedl/symfony
that referenced
this pull request
Jun 30, 2019
- this PR is related to symfony#32241
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…jschaedl) This PR was squashed before being merged into the 4.4 branch (closes #32269). Discussion ---------- [PropertyAccess] Adds entries to CHANGELOG and UPGRADE | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A In PR #32241 I missed to add entries to the CHANGELOG and UPGRADE file. Commits ------- c4afbf3 [PropertyAccess] Adds entries to CHANGELOG and UPGRADE
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #32234 (comment)