[Validator] pass error code as a string #32244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 28, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
What's the goal of this change? |
xabbuh
commented
Jun 28, 2019
| @@ -528,7 +528,7 @@ public function testAddCustomizedViolation() | |||
| $this->assertSame($entity, $violations[0]->getRoot()); | |||
| $this->assertSame('Invalid value', $violations[0]->getInvalidValue()); | |||
| $this->assertSame(2, $violations[0]->getPlural()); | |||
| $this->assertSame(42, $violations[0]->getCode()); | |||
| $this->assertSame('42', $violations[0]->getCode()); | |||
There was a problem hiding this comment.
The argument is documented as string in ConstraintViolationBuilderInterface::setCode(). When adding type-hints in 5.0, we will need to compare the returned code with the string '42'. Making the change in the test here makes it consistent across all branches.
nicolas-grekas
approved these changes
Jun 28, 2019
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] pass error code as a string | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 901fe0d pass error code as a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.