[DI] Add compiler pass and command to check that services wiring matches type declarations #32256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Jun 28, 2019
src/Symfony/Component/DependencyInjection/Compiler/CheckTypeHintsPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/CheckTypeHintsPass.php
Outdated
Show resolved
Hide resolved
220c681 to
cca6826
Compare
|
The failure is expected (the pass is not available yet when executing the Framework bundle tests). |
Simperfit
reviewed
Jul 3, 2019
src/Symfony/Component/DependencyInjection/Exception/InvalidParameterTypeHintException.php
Outdated
Show resolved
Hide resolved
Simperfit
reviewed
Jul 3, 2019
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php
Outdated
Show resolved
Hide resolved
|
Nice feature ! |
0cc5ae0 to
f64d9a9
Compare
0eb486f to
c0743cb
Compare
nicolas-grekas
approved these changes
Oct 12, 2019
There was a problem hiding this comment.
PR is now able to lint the container of the Symfony Demo app successfully.
The core of the PR is the new CheckTypeDeclarationsPass.
The feature is totally opt-in so that it's totally safe merging:
- the pass is not wired by default - it runs only if one enables it in their
Kernel(ppl from the strict camp will like doing so) - the logic runs on-demand also when executing the
lint:containercommand
I enabled the pass in functional tests, for dogfooding :)
yceruto
reviewed
Oct 12, 2019
c0743cb to
8230a15
Compare
chalasr
approved these changes
Oct 14, 2019
| @@ -17,7 +17,7 @@ | |||
| </service> | |||
| <service id="Symfony\Component\Validator\Validator\ValidatorInterface" alias="validator" /> | |||
|
|
|||
| <service id="validator.builder" class="Symfony\Component\Validator\ValidatorBuilderInterface"> | |||
| <service id="validator.builder" class="Symfony\Component\Validator\ValidatorBuilder"> | |||
|
Thank you @GuilhemN. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2019
…ces wiring matches type declarations (alcalyn, GuilhemN, nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] Add compiler pass and command to check that services wiring matches type declarations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27744 | License | MIT | Doc PR | PR replacing #27825. It adds a `lint:container` command asserting the type hints used in your code are correct. Commits ------- 8230a15 Make it really work on real apps 4b3e9d4 Fix comments, improve the feature a6292b9 [DI] Add compiler pass to check arguments type hint
|
And thank you @alcalyn too! |
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replacing #27825.
It adds a
lint:containercommand asserting the type hints used in your code are correct.