[FrameworkBundle] Require symfony/debug #32270
Conversation
| @@ -20,6 +20,7 @@ | |||
| "ext-xml": "*", | |||
| "symfony/cache": "^4.3|^5.0", | |||
| "symfony/config": "^4.2|^5.0", | |||
| "symfony/debug": "^4.4|^5.0", | |||
There was a problem hiding this comment.
Shouldn't it be in the require-dev section instead?
There was a problem hiding this comment.
That wouldn't fix the issue then as the dev dependencies are only applied if they are part of the root project's composer.json file.
There was a problem hiding this comment.
We should also update the FB recipe (public/index.php) and check by class_exists(Debug::class) too? inline with the bin/console recipe.
There was a problem hiding this comment.
So this should be part of the https://github.com/symfony/skeleton/blob/master/composer.json instead? in require-dev?
There was a problem hiding this comment.
Maybe with #32270 (comment) we solve the issue.
There was a problem hiding this comment.
The main problem are the existing applications. Especially because you get a fully white page (500 error) since the ErrorCatcher error handler and exception hander were never registered.
I guess Flex can update the front controller index.php file but is it automatic ? Checking if the class exists would make the error disappear but that would change the default current behavior. That would mean that every project would need to require symfony/debug manually. That would be better but I guess that implies a lot of communication.
AFAIK, Flex cannot add a dependency to the composer.json file right?
There was a problem hiding this comment.
Right, It wouldn't solve the problem for actual projects updating to 4.4, but new projects. Meanwhile, let's fix it for the new ones.
|
Something similar was declined in #32004 |
|
👎 , that's a hack. |
In https://github.com/symfony/symfony/pull/32227/files#diff-9abb1cf74d470e961cc3fb6b0dc3b781L23 the
symfony/debugdependency was removed from theHttpKernelcomponent because all the features that were used from theDebugcomponent are now in theErrorCatchercomponent.I just updated the dependencies of an existing project to the
4.4.x-devversions and got a problem : thesymfony/debugpackage was removed, because the only package that was requiring it wassymfony/http-kernel.Since there is a call to
Debug::enable()in all front controllers of existing applications, (cf https://github.com/symfony/recipes/blob/fa6571b2a261e137a302c86e9d112a12fa414480/symfony/framework-bundle/4.2/public/index.php), we still need to require it somewhere. I guess we can't expect thousands of projects to add this dependency manually.Adding it in the
FrameworkBundleseems more logical to me than restoring it in theHttpKernelcomponent since the front controller recipe of flex is for this bundle.