[HttpKernel] [5.0] Replace docblocks by type-hints #32276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Fragment/RoutableFragmentRenderer.php
Outdated
Show resolved
Hide resolved
|
Is it still a Draft PR? |
|
@fabpot Hello, yes, tests are failing I need to invest some time to figure it out why |
tigitz
commented
Jul 9, 2019
| @@ -197,7 +197,7 @@ public function write(Request $request, Response $response) | |||
| $entry[1]['vary'] = ['']; | |||
| } | |||
|
|
|||
| if ($entry[1]['vary'][0] != $vary || !$this->requestsMatch($vary, $entry[0], $storedEnv)) { | |||
| if ($entry[1]['vary'][0] != $vary || !$this->requestsMatch($vary ?? '', $entry[0], $storedEnv)) { | |||
There was a problem hiding this comment.
There's a similar test here:
|
Failing tests are unrelated |
tigitz
commented
Jul 9, 2019
src/Symfony/Component/HttpKernel/Controller/ArgumentResolverInterface.php
Outdated
Show resolved
Hide resolved
|
Whenever you've got time for another review, thanks in advance. |
|
Thank you @tigitz. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
…ippe Segatori) This PR was merged into the 5.0-dev branch. Discussion ---------- [HttpKernel] [5.0] Replace docblocks by type-hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | continuation of #24722 and checks for #32179 | License | MIT | Doc PR | N/A This PR replaces docblocks by type hints in the HttpKernel component considering #32179. Some docblocks without valuable information got also removed. <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 9e570a2 [Http-Kernel][5.0] Add type-hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces docblocks by type hints in the HttpKernel component considering #32179. Some docblocks without valuable information got also removed.