[HttpClient] Add $response->toStream() to cast responses to regular PHP streams #32290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcd5496 to
764043e
Compare
nicolas-grekas
commented
Jun 30, 2019
764043e to
7c78618
Compare
nicolas-grekas
commented
Jun 30, 2019
6ae8295 to
24ff118
Compare
|
Looks like fabbot has something interesting to say. |
|
Oups, fabbot patch now applied. |
fabpot
approved these changes
Jul 8, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…es to regular PHP streams (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Add $response->toStream() to cast responses to regular PHP streams | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR adds `$response->toStream()` to cast responses to regular PHP streams, and uses the method in `Psr18Client` and `HttplugClient`. This means `Psr18Client` and `HttplugClient` will now be lazy past response headers. I'm not sure any other PSR-18 implementation has this behavior. :) This also adds `StreamWrapper::createResource()` to turn any `ResponseInterface` implementation into a PHP stream. /cc @Nyholm FYI since we discussed about this recently. Commits ------- a59e0af [HttpClient] Add $response->toStream() to cast responses to regular PHP streams
harikt
reviewed
Jul 15, 2019
| } | ||
| } | ||
|
|
||
| public function stream_open(string $path, string $mode, int $options): bool |
There was a problem hiding this comment.
Is this purposeful that the methods are stream_open and not streamOpen . I see this is mixed now . Accidental ?
There was a problem hiding this comment.
My bad, I see where this is ending up. https://www.php.net/manual/en/stream.streamwrapper.example-1.php . Sorry about the comment.
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
$response->toStream()to cast responses to regular PHP streams, and uses the method inPsr18ClientandHttplugClient.This means
Psr18ClientandHttplugClientwill now be lazy past response headers. I'm not sure any other PSR-18 implementation has this behavior. :)This also adds
StreamWrapper::createResource()to turn anyResponseInterfaceimplementation into a PHP stream./cc @Nyholm FYI since we discussed about this recently.