Skip to content

[FrameworkBundle] Add autowiring alias for PSR-14 #32295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

[FrameworkBundle] Add autowiring alias for PSR-14 #32295

merged 1 commit into from
Jul 5, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 30, 2019
@Tobion
Copy link
Contributor

Tobion commented Jun 30, 2019 •
edited
Loading

I think requiring Psr\EventDispatcher would be developer friendlier. Currently developing against \Symfony\Contracts\EventDispatcher\EventDispatcherInterface is quite annoying because there are multiple definitions: one with and one without extending the PSR interface. In phpstorm you cannot simply follow the definition because it asks you to chose every time.

multiple-eventdispatcher

This was done because of the min php version requirement in psr/event-dispatcher, I see. I would suggest to create a minor release of https://packagist.org/packages/symfony/event-dispatcher-contracts that raises php requirement to 7.2 as well and requires psr/event-dispatcher. So people on PHP 7.1 would get the current version and php 7.2 and above the better DX.

@Tobion
Copy link
Contributor

Tobion commented Jul 5, 2019

Thank you @nicolas-grekas.

@Tobion Tobion merged commit 2d5bcda into symfony:4.4 Jul 5, 2019
Tobion added a commit that referenced this pull request Jul 5, 2019
@Tobion
feature #32295 [FrameworkBundle] Add autowiring alias for PSR-14 (nic…
42899cd 
…olas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Add autowiring alias for PSR-14

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

2d5bcda [FrameworkBundle] Add autowiring alias for PSR-14
@nicolas-grekas nicolas-grekas deleted the fwb-psr14 branch July 19, 2019 11:11
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@Tobion Tobion Tobion approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @Tobion @lyrixx @derrabus @carsonbot