[Debug] Restoring back the state of the Debug component (1st step) #32377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ErrorRendeder instead of ErrorDumper? |
|
I will also remove from the current Status: Needs Work |
|
Status: Needs Review (low/high Travis's failures are gone after merge) |
That one is nice too. Personally, I like |
|
Thanks Nicolas! now Travis's low tests pass. Status: Needs Review |
|
It would make sense to me to remove error-catcher from the composer.json of the Debug component. |
6c7570c to
fa47beb
Compare
|
@nicolas-grekas it's done now, thanks. |
fa47beb to
eda49e2
Compare
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2019
…(1st step) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32377). Discussion ---------- [Debug] Restoring back the state of the Debug component (1st step) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32371 | License | MIT After a good discussion with @nicolas-grekas, we made the decision to split the current `ErrorCatcher` component into several: * `ErrorHandler` it would be the Debug component before these changes #31065, with everything related to ErrorHandler, Debug, DebugClassLoader classes and change its name. * `ErrorDumper` it would be the current ErrorCatcher but with FlattenException + the new error renderer system only. This is the first step, then we can deprecate everything for the Debug component in favor of the ErrorHandler and ErrorDumper components, **BUT without moving any code !!**, that would give us more freedom to do it correctly in the new components. NOTE: For this PR I've copy the `Debug` component directory from the revision prior to merged commit #31065 in 4.4 branch. Commits ------- eda49e2 [Debug] Restoring back the state of the Debug component (1st step)
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2019
…nly) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32470). Discussion ---------- Rename ErrorCatcher to ErrorRenderer (rendering part only) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up #32377 Commits ------- fb5b042 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Jul 11, 2019
…nly) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32470). Discussion ---------- Rename ErrorCatcher to ErrorRenderer (rendering part only) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up symfony/symfony#32377 Commits ------- fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter
pushed a commit
to symfony/http-kernel
that referenced
this pull request
Jul 11, 2019
…nly) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32470). Discussion ---------- Rename ErrorCatcher to ErrorRenderer (rendering part only) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up symfony/symfony#32377 Commits ------- fb5b042 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 11, 2019
…nly) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32470). Discussion ---------- Rename ErrorCatcher to ErrorRenderer (rendering part only) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up symfony/symfony#32377 Commits ------- fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
Jul 11, 2019
…nly) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32470). Discussion ---------- Rename ErrorCatcher to ErrorRenderer (rendering part only) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up symfony/symfony#32377 Commits ------- fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
Jan 28, 2020
…nly) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32470). Discussion ---------- Rename ErrorCatcher to ErrorRenderer (rendering part only) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up symfony/symfony#32377 Commits ------- fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a good discussion with @nicolas-grekas, we made the decision to split the current
ErrorCatchercomponent into several:ErrorHandlerit would be the Debug component before these changes Add ErrorHandler component #31065, with everything related to ErrorHandler, Debug, DebugClassLoader classes and change its name.ErrorDumperit would be the current ErrorCatcher but with FlattenException + the new error renderer system only.This is the first step, then we can deprecate everything for the Debug component in favor of the ErrorHandler and ErrorDumper components, BUT without moving any code !!, that would give us more freedom to do it correctly in the new components.
NOTE: For this PR I've copy the
Debugcomponent directory from the revision prior to merged commit #31065 in 4.4 branch.