[DependencyInjection] Deprecated passing Parameter instances as class name to Definition #32390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a800e12 to
853efd1
Compare
|
Failure on AppVeyor is unrelated. |
phansys
suggested changes
Jul 5, 2019
853efd1 to
510fa1f
Compare
|
Status: Needs Review |
Tobion
reviewed
Jul 5, 2019
510fa1f to
11a27fd
Compare
|
Staus: Needs Review |
|
Deprecation warning, see https://travis-ci.org/symfony/symfony/jobs/554806241 |
11a27fd to
f4af95f
Compare
f4af95f to
edfc9d6
Compare
Fixed. I'm going to apply the fix on 4.2 in another PR. |
Tobion
approved these changes
Jul 5, 2019
|
Thank you @derrabus. |
Tobion
added a commit
that referenced
this pull request
Jul 5, 2019
…tances as class name to Definition (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Deprecated passing Parameter instances as class name to Definition | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32279 | License | MIT | Doc PR | N/A This PR deprecates the undocumented possibility to use a `Parameter` instance instead of a string as class name for a `Definition`. This was discovered while working on #32266. Commits ------- edfc9d6 Deprecated passing Parameter instances as class name to Definition.
Tobion
added a commit
that referenced
this pull request
Jul 5, 2019
…rBuilder::register (derrabus) This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Don't pass objects as class name to ContainerBuilder::register | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Fixed a broken test that was discovered while working on #32390. Commits ------- e110603 Don't pass objects as class name to ContainerBuilder::register.
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the undocumented possibility to use a
Parameterinstance instead of a string as class name for aDefinition. This was discovered while working on #32266.