[Intl] Exclude root language #32402
Merged
[Intl] Exclude root language #32402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Intl/Data/Generator/LanguageDataGenerator.php
Outdated
Show resolved
Hide resolved
| @@ -84,7 +84,7 @@ class LanguageDataGenerator extends AbstractDataGenerator | |||
| 'zh' => 'zho', | |||
| ]; | |||
| private static $blacklist = [ | |||
| 'root' => true, | |||
| 'root' => true, // Absolute root language | |||
There was a problem hiding this comment.
I'm sorry but this comment doesn't help much. What about something like: Special non-existent language used for ...
There was a problem hiding this comment.
I dont know what it's used for :) root is not part of the ISO 639-3 codes.
AFAIK it's only used for grouping; if en is a root language, then root is the absolute language root.
fabpot
approved these changes
Jul 8, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was squashed before being merged into the 4.4 branch (closes #32402). Discussion ---------- [Intl] Exclude root language | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Spotted in #32388 Commits ------- 089cc06 [Intl] Exclude root language
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted in #32388