[Translation] deprecate passing a null locale #32415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e477bf2 to
b10b6ae
Compare
ro0NL
reviewed
Jul 7, 2019
derrabus
requested changes
Jul 7, 2019
de68757 to
1adaabc
Compare
|
Status: Needs Review |
Tobion
reviewed
Jul 7, 2019
| @@ -527,7 +549,6 @@ public function getValidLocalesTests() | |||
| { | |||
| return [ | |||
| [''], | |||
| [null], | |||
There was a problem hiding this comment.
this test provider is used in a lot of tests and in most of them a null locale is meant to be supported. so you can't just remove this here.
bca34cf to
c25ced6
Compare
derrabus
approved these changes
Jul 7, 2019
fabpot
requested changes
Jul 8, 2019
src/Symfony/Component/Translation/Tests/MessageCatalogueTest.php
Outdated
Show resolved
Hide resolved
f093ebe to
815024a
Compare
| @@ -184,12 +184,25 @@ public function testAddResourceInvalidLocales($locale) | |||
| */ | |||
| public function testAddResourceValidLocales($locale) | |||
| { | |||
| if (null === $locale) { | |||
| $this->markTestSkipped('null is not a valid locale'); | |||
There was a problem hiding this comment.
why not remove null from getValidLocalesTests instead? this would look legit to me.
There was a problem hiding this comment.
because of #32415 (comment) I don't know it seems that it used in places that can be null
EDIT: Just checked it's used
815024a to
088615d
Compare
fabpot
approved these changes
Jul 8, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Translation] deprecate passing a null locale | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | not needed <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> According to the discussion in #32386 (comment) it seems that allowing null here was not the right thing to do, so we are deprecating this behaviour. Commits ------- 088615d [Translation] deprecate passing a null locale
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in #32386 (comment) it seems that allowing null here was not the right thing to do, so we are deprecating this behaviour.