[Console] don't redraw progress bar more than every 100ms by default #32424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b37628b to
a19c068
Compare
a19c068 to
df551e9
Compare
fabpot
approved these changes
Jul 8, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…0ms by default (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Console] don't redraw progress bar more than every 100ms by default | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no (behavior change) | BC breaks? | no (behavior change) | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #26339 Looks like something we can and should do on 4.4 to me. Commits ------- df551e9 [Console] don't redraw progress bar more than every 100ms by default
| @@ -55,7 +55,7 @@ final class ProgressBar | |||
| * @param OutputInterface $output An OutputInterface instance | |||
| * @param int $max Maximum steps (0 if unknown) | |||
| */ | |||
| public function __construct(OutputInterface $output, int $max = 0, float $minSecondsBetweenRedraws = 0) | |||
| public function __construct(OutputInterface $output, int $max = 0, float $minSecondsBetweenRedraws = 0.1) | |||
There was a problem hiding this comment.
@nicolas-grekas Is the $minSecondsBetweenRedraws param missing in the phpDoc?
There was a problem hiding this comment.
nope: we don't add annotations that don't add value over the signature.
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #26339
Looks like something we can and should do on 4.4 to me.