Skip to content

[Lock] Fix tests #32434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2019
Merged

[Lock] Fix tests #32434

merged 1 commit into from
Jul 8, 2019

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jul 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? nno
Tests pass? yes
Fixed tickets
License MIT
Doc PR none

cc @fabpot fix lock tests.

@fabpot
Copy link
Member

fabpot commented Jul 8, 2019

Can you apply fabbot's patch?

@Simperfit Simperfit force-pushed the feature/fix-lock-tests branch from 0218673 to 5deb0c3 Compare July 8, 2019 14:26
@Simperfit Simperfit force-pushed the feature/fix-lock-tests branch from 5deb0c3 to 2c5089b Compare July 8, 2019 14:27
@fabpot
Copy link
Member

fabpot commented Jul 8, 2019

Thank you @Simperfit.

@fabpot fabpot merged commit 2c5089b into symfony:4.4 Jul 8, 2019
fabpot added a commit that referenced this pull request Jul 8, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] Fix tests

| Q             | A
| ------------- | ---
| Branch?    |   4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | nno <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

cc @fabpot fix lock tests.

Commits
-------

2c5089b [Lock] Fix tests
@Simperfit Simperfit deleted the feature/fix-lock-tests branch July 8, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants