Skip to content

Remove support for Twig 1.x #32458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jul 9, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@fabpot fabpot force-pushed the twig-2-requirement branch from 8bd6873 to 906b3ca Compare July 9, 2019 11:27
@fabpot fabpot merged commit 906b3ca into symfony:master Jul 9, 2019
fabpot added a commit that referenced this pull request Jul 9, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

Remove support for Twig 1.x

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

906b3ca removed support for Twig 1.x
fabpot added a commit that referenced this pull request Jul 9, 2019
…(yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] Deprecating templateExists method

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | not needed

Follow up #32458, so in 5.0 we can remove these methods safely.

I'm not deprecating the `Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()` method because the whole class is being deprecated in #31398

See also #32461

Commits
-------

2e81e45 Deprecating templateExists method
fabpot added a commit that referenced this pull request Jul 9, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[WebProfilerBundle] Removed templateExists method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | not needed

Follow up #32458, since Twig 2.0 the `exists()` method is part of the `LoaderInterface`.

I'm not removing the `Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()` method because the whole class will be removed after #31398

See also #32462

Commits
-------

059113e Removed templateExists method
@fabpot fabpot deleted the twig-2-requirement branch August 5, 2019 16:41
@fabpot fabpot mentioned this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants