[Lock] feature: lock split interface fix post-merge review #32492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9e9045 to
adb0f95
Compare
adb0f95 to
7af9daa
Compare
jderusse
reviewed
Jul 12, 2019
40159e2 to
5d21d9a
Compare
|
Travis failure is not related |
5d21d9a to
1ef05ec
Compare
|
PR rebased |
xabbuh
reviewed
Jul 16, 2019
1ef05ec to
2b93afe
Compare
|
@xabbuh pr updated |
chalasr
requested changes
Jul 17, 2019
2b93afe to
8bb6135
Compare
|
Status: Needs Review |
xabbuh
approved these changes
Jul 17, 2019
8bb6135 to
b77e770
Compare
jderusse
approved these changes
Jul 18, 2019
b77e770 to
8173c47
Compare
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 18, 2019
…ew (Simperfit) This PR was squashed before being merged into the 4.4 branch (closes #32492). Discussion ---------- [Lock] feature: lock split interface fix post-merge review | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yesish <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> see #32198 (review) Commits ------- 8173c47 [Lock] feature: lock split interface fix post-merge review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #32198 (review)