In other parts of the application I think we said: xlf is the only valid extension for XLIFF files, so we won't add support for xliff extension. See for example #22440.

So, in theory, we shouldn't merge this for consistency ... or we should add support for xliff everywhere we support xlf. I don't have a strong opinion about this.

My opinion is that if symfony is able to load .xliff files (which it is without any problems), it should be able to lint these .xliff files.

On this line (218 on master):

So this pull-request fixes a bug where xliff files are being loaded by the linter (removing that would be a BC break in my opinion), but can't be properly linted because of the wrong regex.

(should target 4.4 btw)

(should target 4.4 btw)

@nicolas-grekas Sorry, I'm unfamiliar with the GitHub branch targeting. I think I screwed this up >.<
I think I will open a new pull-request with your requested changes.

EDIT: Ok, I think I got it reversed, will check how to target 4.4

in strict mode, I'd suggest raising an error when xliff is used

@nicolas-grekas I added another error message if "xliff" is used with strict mode enabled. Could you have a look at it again?

Altough that change does not resolve my issue, because I am using strict mode unintentionally and I found no "easy" way to disable it. The flag to enable strict mode is set to "true" by default in the constructor. I think there should be an option like "--no-strict-mode" to disable it via the command line.

@codegain but why don't you use the xlf extension? That's the only standard one AFAIK?

@codegain but why don't you use the xlf extension? That's the only standard one AFAIK?

@nicolas-grekas I am using poeditor.com for translations which only works with .xliff files and shows the error "File format unsupported" if an .xlf file is uploaded.

According to a section in the specs for XLIFF 1.2 (http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html):

D.4. XLIFF File Extension
XLIFF documents use the .xlf extension. No other extension is recommended by the specification.

the .xlf extension is recommeded, but not strictly required.

The XLIFF 2.0 specs (http://docs.oasis-open.org/xliff/xliff-core/v2.0/xliff-core-v2.0.html) make no preference towards any file extension.

Did you report the issue to poeditor? That's where the real issue is to me.

@nicolas-grekas Their response:

Since we support only iOS xliff files, we allow imports only with the .xliff extension, because that's the one specific to iOS.
Uploading .xlf files may work after changing the extenstion to .xliff, but if your files are not in the same format as the iOS xliff format, data can get lost during this process.
We have a sample of the iOS xliff format here:
https://poeditor.com/localization/files/xliff

I had no idea that any sort of "iOS xliff" exists, because it works perfectly fine with symfony xlf files (if I change the extension to ".xliff").
I would like that this change makes into the XliffLintCommand, because my current workaround is to

1. rename all files to ".xlf"
2. run the lint:xliff command
3. rename all files back to ".xliff"

Thanks for the details. If everybody else is OK to seamlessly accept .xliff files, let's do it
/cc @symfony/deciders

Thanks for the details. If everybody else is OK to seamlessly accept .xliff files, let's do it

@nicolas-grekas @Tobion Just to clarify: Should the command now seamlessly accept .xliff files (without an additional error message) or raise an error if .xliff is used in strict mode?

I would accept loading both without any messages.

Thank you @codegain.