[Messenger] Extract Dsn object #32566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jul 17, 2019
src/Symfony/Component/Messenger/Transport/AmqpExt/Connection.php
Outdated
Show resolved
Hide resolved
I don't see any problems here. We can use factory method BTW, thanx for review. |
jderusse
reviewed
Aug 21, 2019
2bfdeaa to
c25295d
Compare
|
I hope that there is small change to merge this PR. BC-breaks was documented, old tests fixed, new added. Please, review. // cc @nicolas-grekas @fabpot @sroze |
|
I'm closing now because this would be a BC break and I'm not sure this is worth it. That's an internal refacto that has a significant side effect on the public API, but has no practical side effect on the feature side. Thanks for giving it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During implementing transport factories for Mailer component I decided to extract
Dsnobject in Messenger component also instead of string + array of options.