Skip to content

[Form][Validator] Generate accept attribute with file constraint and mime types option #32580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Form][Validator] Generate accept attribute with file constraint and mime types option #32580

wants to merge 2 commits into from

Conversation

Coosos
Copy link
Contributor

@Coosos Coosos commented Jul 17, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29327
License MIT
Doc PR symfony/symfony-docs#...

Generate the html accept attribute based on the file constraint and mime types option.

Is it necessary to add this feature in the documentation ?

Made with @Timherlaud

@Coosos Coosos requested a review from xabbuh as a code owner July 17, 2019 16:04
@Coosos Coosos changed the title WIP : [Form][Validator] Generate accept attribute with file constraint and mime types option [Form][Validator] Generate accept attribute with file constraint and mime types option Jul 17, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Jul 17, 2019
@nicolas-grekas
Copy link
Member

(should target 4.4)

@Coosos Coosos changed the base branch from master to 4.4 July 17, 2019 18:01
@Coosos Coosos changed the base branch from 4.4 to master July 17, 2019 18:02
@Coosos Coosos force-pushed the feature-mime-types-constraint-form branch from 1188ab0 to fad0381 Compare July 17, 2019 18:16
@Coosos Coosos requested review from dunglas, lyrixx and sroze as code owners July 17, 2019 18:16
@Coosos Coosos changed the base branch from master to 4.4 July 17, 2019 18:16
@Coosos Coosos force-pushed the feature-mime-types-constraint-form branch from fad0381 to ab49f0b Compare July 17, 2019 18:19
@Coosos Coosos force-pushed the feature-mime-types-constraint-form branch 2 times, most recently from 96350db to 6fa1134 Compare July 17, 2019 18:39
@Coosos
Copy link
Contributor Author

Coosos commented Jul 17, 2019

Sorry I have recreated this pull request (#32587) because I missed my rebase

@Coosos Coosos closed this Jul 17, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Coosos @nicolas-grekas @javiereguiluz