Skip to content

[Debug] Fix 3.4 tests #32612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019
Merged

[Debug] Fix 3.4 tests #32612

merged 1 commit into from
Jul 19, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jul 19, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT

@yceruto yceruto changed the title Fix 34 tests Fix 3.4 tests and remove the "translator.logging" service when its deps are unavailable Jul 19, 2019
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 19, 2019
@xabbuh
Copy link
Member

xabbuh commented Jul 19, 2019

I proposed #32615 as an alternative which backports the changes made to tests in #32332.

@nicolas-grekas nicolas-grekas changed the title Fix 3.4 tests and remove the "translator.logging" service when its deps are unavailable [Debug] Fix 3.4 tests Jul 19, 2019
@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit 77fa283 into symfony:3.4 Jul 19, 2019
nicolas-grekas added a commit that referenced this pull request Jul 19, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Fix 3.4 tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Commits
-------

77fa283 Fix Debug component tests
@yceruto yceruto deleted the fix_34_tests branch July 19, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants