[FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion #32617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrameworkBundle had 2 classes called WebTestCase, one of which is only meant for internal tests. To avoid confusion the internal class has been renamed to AbstractWebTestCase 'See symfony#32577
|
This change follows the instructions in the issue, however, I will say it feels wierd that the |
|
Shouldn't this change target 3.4? |
|
Wasn't sure, can gladly open a new PR. |
ro0NL
reviewed
Jul 19, 2019
| @@ -14,7 +14,7 @@ | |||
| use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as BaseWebTestCase; | |||
| use Symfony\Component\Filesystem\Filesystem; | |||
|
|
|||
| class WebTestCase extends BaseWebTestCase | |||
| class AbstractWebTestCase extends BaseWebTestCase | |||
|
So, if I change this to target the 3.4 branch, the patch will not cleanly apply to versions after, as some functional tests were only added in later versions. How should I proceed? |
|
@janvt We can either handle that in follow-up PRs or someone who merges branches up can fix those cases while merging. |
|
So, should I just create one PR for each branch ( |
|
Also just saw, the same is the case in the |
SecurityBundle had 2 classes called WebTestCase, one of which is only meant for internal tests. To avoid confusion the internal class has been renamed to AbstractWebTestCase and made abstract. See symfony#32577
This was referenced Jul 19, 2019
|
I opened 2 PRs against the |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2019
…stCase to avoid confusion (janvt) This PR was squashed before being merged into the 3.4 branch (closes #32625). Discussion ---------- [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase, one of which is only meant for internal tests. To avoid confusion the internal class has been renamed to AbstractWebTestCase and made abstract. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (or, yes, but internal class) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32577 | License | MIT This PR is to ease integration, as not all test classes are present in all currently maintained branches. See #32617 Commits ------- 775d970 [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 23, 2019
…stCase to avoid confusion (janvt) This PR was squashed before being merged into the 3.4 branch (closes #32625). Discussion ---------- [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase, one of which is only meant for internal tests. To avoid confusion the internal class has been renamed to AbstractWebTestCase and made abstract. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (or, yes, but internal class) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32577 | License | MIT This PR is to ease integration, as not all test classes are present in all currently maintained branches. See symfony/symfony#32617 Commits ------- 775d970927 [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2019
…stCase to avoid confusion (janvt) This PR was squashed before being merged into the 4.2 branch (closes #32626). Discussion ---------- [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase, one of which is only meant for internal tests. To avoid confusion the internal class has been renamed to AbstractWebTestCase and made abstract. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (or, yes, but internal class) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32577 | License | MIT This PR is to ease integration, as not all test classes are present in all currently maintained branches. This PR should patch relatively well onto 4.* branches. See #32617 Commits ------- 01aaece [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameworkBundle & SecurityBundle had 2 classes called WebTestCase,
one of which is only meant for internal tests. To avoid confusion the internal
classes have been renamed to AbstractWebTestCase and made abstract.