Skip to content

Remove dead tests fixtures #32623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Once this is merged up to 4.2, I will check 4.2.

@fancyweb fancyweb force-pushed the debug-remove-unused-test-class branch from 96acaf4 to f7e24c2 Compare July 19, 2019 11:52
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 19, 2019
@fancyweb
Copy link
Contributor Author

Pretty sure that the AppVeyor failure is unrelated 😁

@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit f7e24c2 into symfony:3.4 Jul 19, 2019
nicolas-grekas added a commit that referenced this pull request Jul 19, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Remove dead tests fixtures

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Once this is merged up to 4.2, I will check 4.2.

Commits
-------

f7e24c2 Remove dead tests fixtures
@nicolas-grekas
Copy link
Member

Now merged in to 4.2

@fancyweb fancyweb deleted the debug-remove-unused-test-class branch July 19, 2019 12:07
chalasr pushed a commit that referenced this pull request Jul 19, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Remove more dead tests fixtures

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Continuation of #32623

I am sorry but I detected a few more cases.

Commits
-------

a1fb54d Remove more dead tests fixtures
nicolas-grekas added a commit that referenced this pull request Jul 19, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Remove more dead tests fixtures

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Continuation of #32623

I am sorry but I detected a few more cases.

Commits
-------

a1fb54d Remove more dead tests fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants