[FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion #32626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be rebased now. |
|
done. |
xabbuh
approved these changes
Jul 23, 2019
388bdcb to
01aaece
Compare
|
Thank you @janvt. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2019
…stCase to avoid confusion (janvt) This PR was squashed before being merged into the 4.2 branch (closes #32626). Discussion ---------- [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase, one of which is only meant for internal tests. To avoid confusion the internal class has been renamed to AbstractWebTestCase and made abstract. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (or, yes, but internal class) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32577 | License | MIT This PR is to ease integration, as not all test classes are present in all currently maintained branches. This PR should patch relatively well onto 4.* branches. See #32617 Commits ------- 01aaece [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase,
one of which is only meant for internal tests. To avoid confusion the internal
class has been renamed to AbstractWebTestCase and made abstract.
This PR is to ease integration, as not all test classes are present in all currently
maintained branches. This PR should patch relatively well onto 4.* branches.
See #32617