Remove more dead tests fixtures #32627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bb4fa0 to
a1fb54d
Compare
xabbuh
approved these changes
Jul 19, 2019
chalasr
approved these changes
Jul 19, 2019
|
Thank you @fancyweb. |
1 similar comment
|
Thank you @fancyweb. |
chalasr
pushed a commit
that referenced
this pull request
Jul 19, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Remove more dead tests fixtures | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Continuation of #32623 I am sorry but I detected a few more cases. Commits ------- a1fb54d Remove more dead tests fixtures
|
race condition :) |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 19, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Remove more dead tests fixtures | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Continuation of #32623 I am sorry but I detected a few more cases. Commits ------- a1fb54d Remove more dead tests fixtures
Tobion
added a commit
that referenced
this pull request
Jul 24, 2019
…cyweb) This PR was merged into the 3.4 branch. Discussion ---------- [PropertyAccess] Fix PropertyAccessorCollectionTest | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In #32627, I (a script actually) removed 2 fixtures classes from this test class. They are actually used but by tests that don't fail without them 😁 (because they were mocked and it's possible to mock non existing classes). This PR restores those 2 classes and remove the unneeded mocks so the tests use the real classes and are actually useful. Commits ------- a310bac [PropertyAccess] Fix PropertyAccessorCollectionTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #32623
I am sorry but I detected a few more cases.