[Form] repeat preferred choices in list of all choices #32658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 22, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10271 |
| License | MIT |
| Doc PR |
|
See #23690 |
|
|
|
Maybe I misunderstood but if I didn't fixed the test on my previous PR it's because regarding the comments I thought we had to introduce this as a new optional feature (with a new option). But maybe I am wrong |
nicolas-grekas
approved these changes
Jul 23, 2019
|
@Seb33300 I think we should revisit the decision made back then. This only improves the rendering. Adding an extra option for this seems to be unneeded complexity. |
|
Back then the PR was not completed, so we didn't make any decision :) |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 24, 2019
… (Seb33300, xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [Form] repeat preferred choices in list of all choices | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10271 | License | MIT | Doc PR | Commits ------- 475c7a4 adapt tests b946b11 [Form] Repeat preferred choices in the main list
This was referenced Nov 12, 2019
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Oct 5, 2023
…oiceType` (arnaud-deabreu) This PR was merged into the 6.4 branch. Discussion ---------- [Form] Add `duplicate_preferred_choices` option to `ChoiceType` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #35135 | License | MIT | Doc PR | TODO I've reintroduced layout tests as they were before #32658, is that enough? /cc `@xabbuh` :) Thanks `@HeahDude` for your mentoring! Commits ------- df00a5f [Form] Add `duplicate_preferred_choices` option to `ChoiceType`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.