Ignore missing translation dependency in FrameworkBundle #32664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using symfony/framework-bundle with symfony/validator installed but without symfony/translation, the call to setTranslator will error out because of the missing translator service. Thus, the call to setTranslator needs to ignore a missing translator dependency to support this scenario.
b2cdba8 to
19eb90d
Compare
xabbuh
approved these changes
Jul 22, 2019
chalasr
approved these changes
Jul 22, 2019
Tobion
approved these changes
Jul 22, 2019
|
Thank you @alcaeus. |
Tobion
added a commit
that referenced
this pull request
Jul 22, 2019
… (alcaeus) This PR was merged into the 3.4 branch. Discussion ---------- Ignore missing translation dependency in FrameworkBundle | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This applies the fix from #31156 to the validator.xml file. The error came up a couple of times in the test suite for DoctrineBundle. When using `symfony/framework-bundle` with `symfony/validator` installed but without `symfony/translation`, the call to `setTranslator` will error out because of the missing `translator` service. Thus, the call to `setTranslator` needs to ignore a missing translator dependency to support this scenario. I don't know how to best test this since the translation component is present in the `require-dev` directive of FrameworkBundle's `composer.json`. If you have any suggestions how to achieve this, please let me know. Commits ------- 19eb90d Ignore missing translation dependency in FrameworkBundle
alcaeus
added a commit
to alcaeus/DoctrineBundle
that referenced
this pull request
Jul 30, 2019
…nslator See symfony/symfony#32664 for details.
alcaeus
added a commit
to alcaeus/DoctrineBundle
that referenced
this pull request
Jul 30, 2019
…nslator See symfony/symfony#32664 for details.
alcaeus
added a commit
to alcaeus/DoctrineBundle
that referenced
this pull request
Jul 30, 2019
…nslator See symfony/symfony#32664 for details.
alcaeus
added a commit
to alcaeus/DoctrineBundle
that referenced
this pull request
Jul 30, 2019
…nslator See symfony/symfony#32664 for details.
alcaeus
added a commit
to alcaeus/DoctrineBundle
that referenced
this pull request
Jul 30, 2019
…nslator See symfony/symfony#32664 for details.
alcaeus
added a commit
to alcaeus/DoctrineBundle
that referenced
this pull request
Aug 24, 2019
…nslator See symfony/symfony#32664 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the fix from #31156 to the validator.xml file. The error came up a couple of times in the test suite for DoctrineBundle. When using
symfony/framework-bundlewithsymfony/validatorinstalled but withoutsymfony/translation, the call tosetTranslatorwill error out because of the missingtranslatorservice. Thus, the call tosetTranslatorneeds to ignore a missing translator dependency to support this scenario.I don't know how to best test this since the translation component is present in the
require-devdirective of FrameworkBundle'scomposer.json. If you have any suggestions how to achieve this, please let me know.