Skip to content

[VarDumper] added support for Imagine/Image #32683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2019
Merged

[VarDumper] added support for Imagine/Image #32683

merged 1 commit into from
Jul 27, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jul 23, 2019 •
edited
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

image

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 24, 2019
@lyrixx lyrixx force-pushed the dumper-image branch 3 times, most recently from d229015 to f85fe88 Compare July 24, 2019 16:27
@lyrixx
Copy link
Member Author

lyrixx commented Jul 24, 2019

Here we go. I rewrite everything, I hope you will like it

@lyrixx lyrixx force-pushed the dumper-image branch 2 times, most recently from 26f8dcb to 92f942c Compare July 24, 2019 16:48
@lyrixx
Copy link
Member Author

lyrixx commented Jul 26, 2019

OK, I updated the PR thanks to @nicolas-grekas
Now the image is collapsed by default, and you can click on the caret to display it
image

@fabpot
Copy link
Member

fabpot commented Jul 27, 2019

Thank you @lyrixx.

@fabpot fabpot mentioned this pull request Jul 27, 2019
Closed
@fabpot fabpot merged commit c8d420d into symfony:4.4 Jul 27, 2019
fabpot added a commit that referenced this pull request Jul 27, 2019
@fabpot
feature #32683 [VarDumper] added support for Imagine/Image (lyrixx)
65f0d6f 
This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] added support for Imagine/Image

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

![image](https://user-images.githubusercontent.com/408368/61811135-19c5a000-ae41-11e9-88f1-9f5823e9ca80.png)

Commits
-------

c8d420d [VarDumper] added support for Imagine/Image
@lyrixx lyrixx deleted the dumper-image branch July 27, 2019 11:07
@chalasr chalasr mentioned this pull request Aug 10, 2019
Closed
@OskarStark OskarStark mentioned this pull request Aug 19, 2019
Merged
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed VarDumper
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@lyrixx @fabpot @javiereguiluz @nicolas-grekas @stof @carsonbot