[HttpClient] rewind stream when using Psr18Client #32689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7f647a to
7f4362b
Compare
fabpot
approved these changes
Jul 24, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 24, 2019
…-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] rewind stream when using Psr18Client | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#11996 | License | MIT | Doc PR | - This is not a bug fix technically but just how PSR-7 works. I'm glad we did not make it a first-class thing in Symfony. This makes it a bit more practicable if it can be... Commits ------- 7f4362b [HttpClient] rewind stream when using Psr18Client
fabpot
added a commit
that referenced
this pull request
Jul 24, 2019
…grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] rewind streams created from strings | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #32689 for 4.4 Commits ------- 33ed4e4 [HttpClient] rewind streams created from strings
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a bug fix technically but just how PSR-7 works.
I'm glad we did not make it a first-class thing in Symfony.
This makes it a bit more practicable if it can be...