Skip to content

[WebProfilerBundle] mark all classes as internal #32698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Jul 24, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

those classes are not meant as extension point

those classes are not meant as extension point
@fabpot
Copy link
Member

fabpot commented Jul 24, 2019

Thank you @Tobion.

@fabpot fabpot merged commit 35b0d57 into symfony:4.4 Jul 24, 2019
fabpot added a commit that referenced this pull request Jul 24, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] mark all classes as internal

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

those classes are not meant as extension point

Commits
-------

35b0d57 [WebProfilerBundle] mark all classes as internal
@Tobion Tobion deleted the internal-web-profiler branch July 24, 2019 16:42
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
yceruto added a commit that referenced this pull request Nov 7, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[WebProfilerBundle] Clean @internal annotations

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Clean remaining `@internal` added by #32698

Commits
-------

7df469b [WebProfilerBundle] Clean @internal annotations
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants