[DI] fix perf issue with lazy autowire error messages #32715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56b244a to
3c3bda5
Compare
|
Benefit confirmed in #32711, ready. |
stof
requested changes
Jul 26, 2019
| $container->setAliases($this->container->getAliases()); | ||
| $container->setDefinitions($this->container->getDefinitions()); | ||
| $container->setResourceTracking(false); | ||
| if (null === $this->typesClone->container) { |
There was a problem hiding this comment.
the container property should be declared as a private property of the class. We don't want to make it a dynamic public property.
There was a problem hiding this comment.
There was a problem hiding this comment.
ah, I missed the fact it was an inherited property. All good then.
stof
approved these changes
Jul 26, 2019
Tobion
approved these changes
Jul 26, 2019
|
Thank you @nicolas-grekas. |
Tobion
added a commit
that referenced
this pull request
Jul 26, 2019
…olas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [DI] fix perf issue with lazy autowire error messages | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32711 | License | MIT | Doc PR | - See linked issue. Commits ------- 3c3bda5 [DI] fix perf issue with lazy autowire error messages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See linked issue.