[Messenger] Fix redis last error not cleared between calls #32726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
suggested changes
Jul 25, 2019
src/Symfony/Component/Messenger/Tests/Transport/RedisExt/ConnectionTest.php
Show resolved
Hide resolved
fabpot
approved these changes
Jul 27, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2019
… (chalasr) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fix redis last error not cleared between calls | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Not clearing it gives misleading errors coming from previous calls which makes debugging hard. @alexander-schranz FYI Commits ------- 9c263ff [Messenger] Fix redis last error not cleared between calls
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not clearing it gives misleading errors coming from previous calls which makes debugging hard.
@alexander-schranz FYI