Skip to content

[Mailer] Make transport factory test case public #32749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jul 25, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes, failures looks like irrelevant
Fixed tickets -
License MIT
Doc PR -

TransportFactoryTestCase could be useful when you adding custom transport and need cover their transport factory with tests.

@fabpot fabpot added the Mailer label Jul 26, 2019
@fabpot fabpot added this to the next milestone Jul 26, 2019
@fabpot
Copy link
Member

fabpot commented Jul 26, 2019

Thank you @Koc.

@fabpot fabpot merged commit 5d64009 into symfony:4.4 Jul 26, 2019
fabpot added a commit that referenced this pull request Jul 26, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Make transport factory test case public

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes, failures looks like irrelevant
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

`TransportFactoryTestCase` could be useful when you adding custom transport and need cover their transport factory with tests.

Commits
-------

5d64009 [Mailer] Make transport factory test case public
@Koc Koc deleted the mailer-make-test-case-public branch July 26, 2019 13:22
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants