[Form][DX] derive default timezone from reference_date option when possible #32762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Can you also add a test for this? |
|
Test added. |
xabbuh
approved these changes
Jul 29, 2019
|
Thank you @yceruto. |
xabbuh
added a commit
that referenced
this pull request
Jul 29, 2019
… option when possible (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [Form][DX] derive default timezone from reference_date option when possible | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Currently, when `reference_date` and `model_timezone` are provided but are not the same, we get a validation exception: https://github.com/symfony/symfony/blob/9216cb75ac11db014262f2d7fe5cb77b0b54db59/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php#L48-L50 But that happen even if the `model_timezone` is `null` ! I propose to relax this behavior by passing the time zone of the configured `reference_date` to this `model_timezone` (by default), thus avoiding annoyances. Commits ------- a62feea [DX] derive default timezone from reference_date option when possible
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
reference_dateandmodel_timezoneare provided but are not the same, we get a validation exception:symfony/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php
Lines 48 to 50 in 9216cb7
But that happen even if the
model_timezoneisnull!I propose to relax this behavior by passing the time zone of the configured
reference_dateto thismodel_timezone(by default), thus avoiding annoyances.