[Console] Get dimensions from stty on windows if possible #32763
Conversation
|
Had to refactor Terminal into a singleton otherwise it couldn't be tested when mocking out the env. It was practically one already due to the static properties. |
|
@rtek Tests must not impact our code. I would highly suggest to remove the singleton and find a way to test the code in another way. |
|
@fabpot Understood - reverted the public API changes. Re |
| private static $width; | ||
| private static $height; | ||
| private $width; | ||
| private $height; |
There was a problem hiding this comment.
I think they were static as a way to cache the values.
There was a problem hiding this comment.
Agreed, but only in a non application context. Application sets env COLUMNS/LINES from the calculated values in Terminal, which then provides caching since Terminal always checks the env first. Only those who instantiate Terminal outside of an application and did not reuse the instance would lose the cache. If this is not acceptable then I would have to use reflection to get the test coverage - is that OK?
There was a problem hiding this comment.
Looking at the code base, I can see that we are instantiating a Terminal instance several times (the instance is not shared).
|
Reverted to maintain the static cache convention and used reflection to test. Test failures on unrelated component. |
|
PR target changed from 4.3 to 3.4 as the bug also exists there. |
|
Thank you @rtek. |
…(rtek) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Get dimensions from stty on windows if possible | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `Console\Terminal` is modified to extract width/height settings to from `stty` on windows if possible. Previously such values were extracted from `mode CON`. If another terminal is in use (eg, gitbash) then the incorrect values would be applied. Commits ------- 5265080 [Console] Get dimensions from stty on windows if possible
Console\Terminalis modified to extract width/height settings to fromsttyon windows if possible. Previously such values were extracted frommode CON. If another terminal is in use (eg, gitbash) then the incorrect values would be applied.