Skip to content

[DoctrineBridge] add parameter type declarations where possible #32769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2019
Merged

[DoctrineBridge] add parameter type declarations where possible #32769

merged 1 commit into from
Jul 27, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 27, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets part of #32179
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.0 milestone Jul 27, 2019
@xabbuh xabbuh requested a review from dunglas as a code owner July 27, 2019 05:58
@xabbuh xabbuh force-pushed the issue-32179-doctrine-bridge branch from 1a6454d to 2663464 Compare July 27, 2019 05:59
@derrabus derrabus mentioned this pull request Jul 27, 2019
Closed
57 tasks
@xabbuh
Copy link
Member Author

xabbuh commented Jul 27, 2019

changes for private methods backported to 4.2 in #32771

@fabpot
Copy link
Member

fabpot commented Jul 27, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 2663464 into symfony:master Jul 27, 2019
fabpot added a commit that referenced this pull request Jul 27, 2019
@fabpot
minor #32769 [DoctrineBridge] add parameter type declarations where p…
7d64644 
…ossible (xabbuh)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[DoctrineBridge] add parameter type declarations where possible

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #32179
| License       | MIT
| Doc PR        |

Commits
-------

2663464 add parameter type declarations where possible
@xabbuh xabbuh deleted the issue-32179-doctrine-bridge branch July 27, 2019 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @fabpot @carsonbot