[Messenger] Fix incompatibility with FrameworkBundle <4.3.1 #32792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc9a246 to
7a60820
Compare
linaori
suggested changes
Jul 29, 2019
There was a problem hiding this comment.
I think an extra addition should include a type check on the argument in the command, as it's never enforced. While I don't think this is a common case, using it without the framework bundle should also give a clear error rather than an invalid method call run-time.
if ($routableBus instanceof ContainerInterface) {
$routableBus = new RoutableMessageBus($routableBus);
} elseif (!$routableBus instanceof RoutableMessageBus) {
throw new ...;
}7a60820 to
5d73970
Compare
|
@linaori check added, thanks! |
fabpot
approved these changes
Aug 5, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2019
…1 (chalasr) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fix incompatibility with FrameworkBundle <4.3.1 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32738 | License | MIT | Doc PR | - Aims to fix an edge case where you install (or upgrade to) symfony/messenger >=4.3.1 while having symfony/framework-bundle <4.3.1 installed. Commits ------- 5d73970 [Messenger] Fix incompatibility with FrameworkBundle <4.3.1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix an edge case where you install (or upgrade to) symfony/messenger >=4.3.1 while having symfony/framework-bundle <4.3.1 installed.