[ErrorHandler] Added type declarations where possible #32812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yceruto
requested changes
Jul 30, 2019
src/Symfony/Component/ErrorHandler/Exception/FatalErrorException.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ErrorHandler/Tests/Fixtures/LoggerThatSetAnErrorHandler.php
Show resolved
Hide resolved
yceruto
reviewed
Jul 30, 2019
5 tasks
yceruto
reviewed
Jul 30, 2019
yceruto
reviewed
Jul 30, 2019
|
could you please also remove the useless |
yceruto
reviewed
Jul 30, 2019
yceruto
approved these changes
Jul 30, 2019
|
various checks seem fine for me locally: $> php ./phpunit src/Symfony/Bundle/SecurityBundle/
#...
OK (231 tests, 679 assertions)$> docker run -it --rm --name spu -v "$PWD":/usr/src/spu -w /usr/src/spu php:7.2.19-cli php ./phpunit src/Symfony/Component/HttpClient
#...
OK, but incomplete, skipped, or risky tests!
Tests: 245, Assertions: 511, Skipped: 5.$> php ./phpunit src/Symfony/Component/ErrorHandler/
#...
OK (64 tests, 196 assertions)php version 7.2.20 |
|
@tweichart don't worry about AppVeyor's failure, it's not related to your changes. |
Tobion
suggested changes
Jul 30, 2019
src/Symfony/Component/ErrorHandler/Exception/SilencedErrorContext.php
Outdated
Show resolved
Hide resolved
yceruto
approved these changes
Jul 31, 2019
yceruto
added a commit
that referenced
this pull request
Jul 31, 2019
…chart) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] minor fix for wrong method name case | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Minor replacement of wrong case for function name, needs to be fixed in 3.4 as hinten [here](#32812 (comment)). Commits ------- 8b2d67b minor fix for wrong case
Tobion
reviewed
Jul 31, 2019
Tobion
approved these changes
Jul 31, 2019
3b952e1 to
ab6aae1
Compare
|
Thank you @tweichart. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 31, 2019
…obias Weichart) This PR was squashed before being merged into the 4.4 branch (closes #32812). Discussion ---------- [ErrorHandler] Added type declarations where possible | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've added type declarations where possible (method parameters & return types). DocBlocks were replaced too if the type declarations made them redundant. Void returns were replaced whenever necessary. Also on one occasion the setting of the exceptionHandler was replaced by a function call, which did practically the same thing. Commits ------- ab6aae1 [ErrorHandler] Added type declarations where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added type declarations where possible (method parameters & return types). DocBlocks were replaced too if the type declarations made them redundant.
Void returns were replaced whenever necessary.
Also on one occasion the setting of the exceptionHandler was replaced by a function call, which did practically the same thing.