-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpKernel] Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler #32818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure this is the correct fix. Can you check what "urlFormat" is in the constructor, when this happens? Maybe a callback is passed, and this callback has the bug? |
I've already reviewed it @nicolas-grekas You can also see the "urlFormat" in the following path:
|
OK, thanks for the reminder, works for me. |
A test case with PHPUnit ? |
Yes please |
@Arman-Hosseini creating a test for this is not a trivial thing so, if you need help, you can copy+paste this test and make the needed changes to test your feature:
|
Hello @nicolas-grekas and @javiereguiluz . |
Yes, please do add a method on the class that'd be perfect. |
Thank you @Arman-Hosseini. |
…e wrong URL in Profiler (Arman-Hosseini) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler | Q | A | ------------- | --- | Branch? | >= 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32444 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> I had this problem and I noticed that an issue had already been registered. So I registered the pull request. Commits ------- 9ed5f03 Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler
I had this problem and I noticed that an issue had already been registered.
So I registered the pull request.