Adopt @PHPUnit55Migration:risky rule of php-cs-fixer
#32884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Aug 2, 2019
| @@ -8,8 +8,7 @@ return PhpCsFixer\Config::create() | |||
| ->setRules([ | |||
| '@Symfony' => true, | |||
| '@Symfony:risky' => true, | |||
| '@PHPUnit48Migration:risky' => true, | |||
| 'php_unit_no_expectation_annotation' => false, // part of `PHPUnitXYMigration:risky` ruleset, to be enabled when PHPUnit 4.x support will be dropped, as we don't want to rewrite exceptions handling twice | |||
| '@PHPUnit55Migration:risky' => true, | |||
There was a problem hiding this comment.
Can be PHPUnit75Migration:risky
php_unit_dedicate_assert should be configured to with target = 3.5 as all methods are not (yet) pollyfiled (ie assertDirectoryExist) in phpunit 4
|
Closing in favor of #32885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might have to polyfill
createPartialMockbefore merging this one.