[PhpUnitBridge] Add polyfill for methods assertNan, assertFinite and assertInfinite #32886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffc44f1 to
e4282bd
Compare
1 task
e4282bd to
7b95f43
Compare
7b95f43 to
3450c17
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
…rtFinite and assertInfinite (jderusse) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Add polyfill for methods assertNan, assertFinite and assertInfinite | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA Provide pollyfile for methods `assertFinite`, `assertInfinite` and `assertNan` Commits ------- 3450c17 [PhpUnitBridge] Add polyfill for methods assertNan, assertFinite and assertInfinite
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
…las-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Use PHPUnit75Migration in CS fixer | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (not yet) need #32882, #32886, #32893 | Fixed tickets | #32844 | License | MIT | Doc PR | NA Bump php-cs-fixer rule to PHPUnit75Migration:risky which add - php_unit_dedicate_assert_internal_type - php_unit_expectation - php_unit_mock - php_unit_no_expectation_annotation which are (or will be) all polyfillyed - [x] need to polyfill `createPartialMock` Commits ------- 9fb1c42 Adopt `@PHPUnit55Migration:risky` rule of php-cs-fixer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide pollyfile for methods
assertFinite,assertInfiniteandassertNan