Skip to content

[PhpUnitBridge] Polyfill the method createPartialMock #32893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Aug 2, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32844
License MIT
Doc PR NA

Provide a polyfill for createPartialMock required by #32885

@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit a68c16d into symfony:4.4 Aug 3, 2019
nicolas-grekas added a commit that referenced this pull request Aug 3, 2019
…derusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Polyfill the method createPartialMock

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

Provide a polyfill for `createPartialMock` required by #32885

Commits
-------

a68c16d Polyfill the method createPartialMock
nicolas-grekas added a commit that referenced this pull request Aug 3, 2019
…las-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Use PHPUnit75Migration in CS fixer

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes (not yet) need #32882, #32886, #32893
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

Bump php-cs-fixer rule to PHPUnit75Migration:risky which add
- php_unit_dedicate_assert_internal_type
- php_unit_expectation
- php_unit_mock
- php_unit_no_expectation_annotation

which are (or will be) all polyfillyed

- [x] need to polyfill `createPartialMock`

Commits
-------

9fb1c42 Adopt `@PHPUnit55Migration:risky` rule of php-cs-fixer
@jderusse jderusse deleted the polyfill-createPartialMock branch August 8, 2019 11:36
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants