Skip to content

[Mailer] Add message events logger #32927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 4, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets refs #31592, refs #32409, refs #31947, refs #31747
License MIT
Doc PR n/a

To allow testing emails and for the web profiler, we need a way to store all sent/queued messages.

@fabpot fabpot force-pushed the mailer-event-logs branch 3 times, most recently from 2a2b0fc to 8fb41c0 Compare August 4, 2019 13:39
@nicolas-grekas nicolas-grekas added this to the next milestone Aug 4, 2019
@fabpot fabpot force-pushed the mailer-event-logs branch from 8fb41c0 to 33cf603 Compare August 4, 2019 15:05
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with just some nitpicking :)

@fabpot fabpot force-pushed the mailer-event-logs branch 2 times, most recently from a0b4f91 to cde7977 Compare August 4, 2019 15:12
@fabpot fabpot force-pushed the mailer-event-logs branch from cde7977 to 7642178 Compare August 4, 2019 15:13
@fabpot fabpot merged commit 7642178 into symfony:4.4 Aug 4, 2019
fabpot added a commit that referenced this pull request Aug 4, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Add message events logger

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | refs #31592, refs #32409, refs #31947, refs #31747
| License       | MIT
| Doc PR        | n/a

To allow testing emails and for the web profiler, we need a way to store all sent/queued messages.

Commits
-------

7642178 [Mailer] added message events logger
@xabbuh xabbuh added the Mailer label Aug 5, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
chapa added a commit to chapa/symfony that referenced this pull request Nov 21, 2019
* Class `SmtpEnvelope` has been renamed to `Envelope` in symfony#33562
* A required `$transport` argument has been added to `MessageEvent` in  symfony#32927
fabpot added a commit that referenced this pull request Nov 22, 2019
…vent (chapa)

This PR was squashed before being merged into the 5.1-dev branch (closes #34475).

Discussion
----------

[Mailer] Add UPGRADE entries about Envelope and MessageEvent

* Class `SmtpEnvelope` has been renamed to `Envelope` in #33562
* A required `$transport` argument has been added to `MessageEvent` in  #32927

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | already up-to-date

Commits
-------

7baa295 [Mailer] Add UPGRADE entries about Envelope and MessageEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants