Use assertContainsEquals when needed #32969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5a24ef to
95ff93c
Compare
95ff93c to
f842e59
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Use assertContainsEquals when needed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR replaces deprecated paramèter `$checkForObjectIdentity` of methods `assertContains` by the dedicated method `assertContainsEquals` Commits ------- f842e59 Use assert assertContainsEquals when needed
23 tasks
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-Wikibase
that referenced
this pull request
Mar 19, 2020
Checking for equality without the check for object identity ($checkForObjectIdentity = false) is deprecated and will be removed in PHPUnit 9 - a warning was emitted. Use assertContainsEquals instead. Cf. e.g. symfony/symfony#32969 Change-Id: Id1d30691a1a0793fabfb07b2ae59ec96c9465131
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions
that referenced
this pull request
Mar 19, 2020
* Update Wikibase from branch 'master'
to 09d9f06850ad52bcfbd1eb62492769ac446f95df
- Merge "phpunit tests: use assertContainsEquals when needed"
- phpunit tests: use assertContainsEquals when needed
Checking for equality without the check for object identity
($checkForObjectIdentity = false) is deprecated and will be removed in
PHPUnit 9 - a warning was emitted. Use assertContainsEquals instead.
Cf. e.g. symfony/symfony#32969
Change-Id: Id1d30691a1a0793fabfb07b2ae59ec96c9465131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces deprecated paramèter
$checkForObjectIdentityof methodsassertContainsby the dedicated methodassertContainsEquals