Skip to content

[Messenger] Don't deep-merge senders configuration #32970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

[Messenger] Don't deep-merge senders configuration #32970

merged 1 commit into from
Sep 16, 2019

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Aug 5, 2019 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32953
License MIT
Doc PR -

@chalasr chalasr added this to the 4.3 milestone Aug 5, 2019
fabpot
fabpot approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we can do it in 4.3.

sroze
sroze approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for the Messenger keys indeed. But shouldn't we do this in 4.4 only because it's still clearly a BC break?

@fabpot
Copy link
Member

fabpot commented Aug 18, 2019

I agree that this should be for 4.4.

nicolas-grekas
nicolas-grekas requested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just putting a "needs work" here, see my last inline comment :)

@chalasr chalasr changed the base branch from 4.3 to 4.4 September 13, 2019 11:21
@chalasr chalasr changed the title [Messenger][HttpClient] Don't deep-merge senders/transports/clients configuration [Messenger] Don't deep-merge senders configuration Sep 13, 2019
@chalasr
Copy link
Member Author

chalasr commented Sep 13, 2019

PR updated to only disable deep merging for the framework.messenger.routing.senders prototype and fix the related ticket. Also rebased on 4.4 with CHANGELOG entry.

As @nicolas-grekas suggests, we need to discuss other parts of the config tree case by case, let's move forward on this one.

@chalasr chalasr modified the milestones: 4.3, next Sep 13, 2019
@fabpot
Copy link
Member

fabpot commented Sep 16, 2019

Thank you @chalasr.

fabpot added a commit that referenced this pull request Sep 16, 2019
@fabpot
bug #32970 [Messenger] Don't deep-merge senders configuration (chalasr)
7f81cb5 
This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Don't deep-merge senders configuration

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32953
| License       | MIT
| Doc PR        | -

Commits
-------

20d19ac [Messenger] Don't deep merge routing.senders config option
@fabpot fabpot merged commit 20d19ac into symfony:4.4 Sep 16, 2019
@chalasr chalasr deleted the no-deep-merge branch September 16, 2019 09:57
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas requested changes

@lyrixx lyrixx lyrixx approved these changes

@sroze sroze sroze approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@chalasr @fabpot @nicolas-grekas @lyrixx @sroze @carsonbot