Remove unneeded phpdocs #33019
Merged
Remove unneeded phpdocs #33019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Aug 7, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
lyrixx
approved these changes
Aug 7, 2019
chalasr
approved these changes
Aug 7, 2019
src/Symfony/Component/HttpKernel/Fragment/HIncludeFragmentRenderer.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Aug 7, 2019
src/Symfony/Component/Form/Extension/Csrf/Type/FormTypeCsrfExtension.php
Outdated
Show resolved
Hide resolved
3273208 to
692a6e7
Compare
|
Thank you @fabpot. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was squashed before being merged into the 4.4 branch (closes #33019). Discussion ---------- Remove unneeded phpdocs | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 692a6e7 Remove unneeded phpdocs
kaznovac
reviewed
Aug 8, 2019
| * @param object $subject | ||
| * @param Marking $marking | ||
| * @param Transition $transition | ||
| * @param WorkflowInterface $workflow |
There was a problem hiding this comment.
$workflow is not typehinted in _constructor
possible types WorkflowInterface|string|null
| * @param Definition $definition A Definition instance | ||
| * @param Marking|null $marking A Marking instance | ||
| * @param array $options An array of options | ||
| * @param array $options An array of options |
| * @param string $class The class name of the loaded objects | ||
| * @param IdReader|null $idReader The reader for the object IDs | ||
| * @param EntityLoaderInterface|null $objectLoader The objects loader | ||
| * @param string $class The class name of the loaded objects |
There was a problem hiding this comment.
typehinted in constructor maybe surplus
| @@ -133,7 +133,6 @@ protected function write($content, $decorated = false) | |||
| * | |||
| * @param Definition|Alias|object $service | |||
| * @param array $options | |||
| * @param KernelInterface $kernel A KernelInterface instance | ||
| * @param TemplateNameParserInterface $parser A TemplateNameParserInterface instance | ||
| * @param string $rootDir The directory where global templates can be stored | ||
| * @param string $rootDir The directory where global templates can be stored |
| @@ -99,7 +99,6 @@ class NativeSessionStorage implements SessionStorageInterface | |||
| * | |||
| * @param array $options Session configuration options | |||
| * @param Request $request The request the kernel is currently processing | ||
| * @param int $requestType The request type the kernel is currently processing; one of | ||
| * HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST | ||
| * @param int $requestType The request type the kernel is currently processing; one of |
| * @param \DOMElement $node Element to parse | ||
| * @param string $path Full path of the XML file being processed | ||
| * @param string $file Loaded file name | ||
| * @param \DOMElement $node Element to parse |
| @@ -24,8 +24,7 @@ interface DumperInterface | |||
| /** | |||
| * Dumps the message catalogue. | |||
| * | |||
| * @param MessageCatalogue $messages The message catalogue | |||
| * @param array $options Options that are used by the dumper | |||
| * @param array $options Options that are used by the dumper | |||
| * caused the violation | ||
| * @param mixed $cause The cause of the violation | ||
| * @param string $message The violation message | ||
| * @param string $messageTemplate The raw violation message |
There was a problem hiding this comment.
lots of |null types can be stated in doc ($message, $messageTemplate, $propertyPath)
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
…ransformer (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- cleanup remaining param $options and internal Intl FullTransformer | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets |#... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | Continuation of #33020 and #33019 Commits ------- 5dbcdc6 cleanup remaining param and internal Intl FulLTransformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.