[Intl] fix nullable phpdocs and useless method visibility of internal class #33020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Aug 7, 2019
| * | ||
| * @return Transformer[] Associative array of Transformer objects (format char => Transformer) | ||
| */ | ||
| public function getTransformers() |
There was a problem hiding this comment.
This is an internal class
There was a problem hiding this comment.
I think we should change this class on 4.4
I get it's internal, but let's keep 3.4 super-stable.
There was a problem hiding this comment.
change reverted while merging
chalasr
approved these changes
Aug 7, 2019
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
…y of internal class (Tobion) This PR was merged into the 3.4 branch. Discussion ---------- [Intl] fix nullable phpdocs and useless method visibility of internal class | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Fix stuff found in #32525 Commits ------- 63b71b5 [Intl] fix nullable phpdocs and useless method visibility of internal class
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
…ransformer (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- cleanup remaining param $options and internal Intl FullTransformer | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets |#... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | Continuation of #33020 and #33019 Commits ------- 5dbcdc6 cleanup remaining param and internal Intl FulLTransformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stuff found in #32525