Skip to content

[HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt #33022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2019
Merged

[HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt #33022

merged 1 commit into from
Aug 8, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 7, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33017
License MIT
Doc PR -

@lyrixx lyrixx changed the base branch from master to 4.3 August 7, 2019 17:05
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Aug 7, 2019
nicolas-grekas
nicolas-grekas approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(failures unrelated)
We use the stream method internally, which also implements timeout management, but it reads network buffers before failing, which this option doesn't.

@lyrixx lyrixx force-pushed the http-client-connect branch from e1f9599 to 679ea90 Compare August 7, 2019 17:21
@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit e289723 into symfony:4.3 Aug 8, 2019
nicolas-grekas added a commit that referenced this pull request Aug 8, 2019
@nicolas-grekas
bug #33022 [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt (ly…
fda49e6 
…rixx)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33017
| License       | MIT
| Doc PR        | -

Commits
-------

e289723 [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
@lyrixx lyrixx deleted the http-client-connect branch August 8, 2019 08:32
@fabpot fabpot mentioned this pull request Aug 26, 2019
Merged
@beberlei beberlei mentioned this pull request Aug 10, 2022
Closed
@deeky666 deeky666 mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @nicolas-grekas @carsonbot