Skip to content

[Console] add missing type hints #33059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Aug 8, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets part of #32179
License MIT
Doc PR

Fix missing types from #32318

@nicolas-grekas nicolas-grekas modified the milestones: next, 5.0 Aug 8, 2019
@nicolas-grekas
Copy link
Member

Thank you @Tobion.

@nicolas-grekas nicolas-grekas merged commit 180c497 into symfony:master Aug 8, 2019
nicolas-grekas added a commit that referenced this pull request Aug 8, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Console] add missing type hints

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | part of #32179
| License       | MIT
| Doc PR        |

Fix missing types from #32318

Commits
-------

180c497 [Console] add missing type hints
@Tobion Tobion deleted the console-types branch August 8, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants